linux-kernel - Re: [PATCH v11 1/6] i2c: designware: Cleaning and comment style fixes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170619162650.nxshcsevyu5pk5vj@ninjato>
Date:   Mon, 19 Jun 2017 18:26:50 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ramiro.Oliveira@...opsys.com, Joao.Pinto@...opsys.com,
        CARLOS.PALMINHA@...opsys.com
Subject: Re: [PATCH v11 1/6] i2c: designware: Cleaning and comment style
 fixes.

On Wed, Jun 14, 2017 at 11:43:21AM +0100, Luis Oliveira wrote:
> The purpose of this commit is to fix some comments and styling in the
> existing code due to the need of reuse this code. What is being made
> here is:
> 
> - Sorted the headers files
> - Corrected some comments style (capital letters, lowcase i2c)
> - Reverse tree in the variables declaration
> - Add/remove empty lines and tabs where needed
> - Fix of misspelled word "endianness" and "transferred"
> - Replaced the return variable "r" with the more standard "ret"
> 
> The value of this, besides the rules of coding style, is because I
> will use this code after and it will make my future patch a lot bigger and
> complicated to review. The work here won't bring any additional work to
> backported fixes because is just style and reordering.
> 
> Signed-off-by: Luis Oliveira <lolivei@...opsys.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)