linux-kernel - Re: [PATCH 1/4] perf ftrace: Show error message when fails to set ftrace files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170619182401.GP3645@kernel.org>
Date:   Mon, 19 Jun 2017 15:24:01 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 1/4] perf ftrace: Show error message when fails to set
 ftrace files

Em Sun, Jun 18, 2017 at 11:22:59PM +0900, Namhyung Kim escreveu:
> It'd be better for debugging to show an error message when it fails to
> setup ftrace for some reason.

Thanks a lot, tested the series, excellent ftrace subset to support in
'perf ftrace'! :-)

- Arnaldo
 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/builtin-ftrace.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
> index 9e0b35cd0eea..966a94fa8200 100644
> --- a/tools/perf/builtin-ftrace.c
> +++ b/tools/perf/builtin-ftrace.c
> @@ -61,6 +61,7 @@ static int __write_tracing_file(const char *name, const char *val, bool append)
>  	int fd, ret = -1;
>  	ssize_t size = strlen(val);
>  	int flags = O_WRONLY;
> +	char errbuf[512];
>  
>  	file = get_tracing_file(name);
>  	if (!file) {
> @@ -75,14 +76,16 @@ static int __write_tracing_file(const char *name, const char *val, bool append)
>  
>  	fd = open(file, flags);
>  	if (fd < 0) {
> -		pr_debug("cannot open tracing file: %s\n", name);
> +		pr_debug("cannot open tracing file: %s: %s\n",
> +			 name, str_error_r(errno, errbuf, sizeof(errbuf)));
>  		goto out;
>  	}
>  
>  	if (write(fd, val, size) == size)
>  		ret = 0;
>  	else
> -		pr_debug("write '%s' to tracing/%s failed\n", val, name);
> +		pr_debug("write '%s' to tracing/%s failed: %s\n",
> +			 val, name, str_error_r(errno, errbuf, sizeof(errbuf)));
>  
>  	close(fd);
>  out:
> -- 
> 2.13.0