linux-kernel - Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdfa1059-17f7-74f7-4b88-2941af07a538@ti.com>
Date:   Tue, 20 Jun 2017 14:03:35 -0500
From:   Dave Gerlach <d-gerlach@...com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>
CC:     Rob Herring <robh+dt@...nel.org>, Tony Lindgren <tony@...mide.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, Keerthy J <j-keerthy@...com>
Subject: Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable
 suspend/resume handlers

Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> +	.arm
>> +	.align 3
>> +
>> +ENTRY(ti_emif_sram)
> 
> Will you ever want to have any of this code as Thumb?

I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.

> 
>> +extern inline void ti_emif_offsets(void)
>> +{
> 
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?

It should be static.

> 
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
> 

No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.

Regards,
Dave