linux-kernel - Re: [PATCH 1/2] hyper-v: check frequency MSRs presence according to the specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2017 21:20:43 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
cc:     devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Jork Loeser <jloeser@...rosoft.com>,
        Ladi Prosek <lprosek@...hat.com>
Subject: Re: [PATCH 1/2] hyper-v: check frequency MSRs presence according to
 the specification

On Mon, 19 Jun 2017, Vitaly Kuznetsov wrote:
> +#define HV_X64_ACCESS_FREQUENCY_MSRS		(1 << 11)
>  
>  /*
>   * Basic SynIC MSRs (HV_X64_MSR_SCONTROL through HV_X64_MSR_EOM
> @@ -73,6 +67,9 @@
>    */
>  #define HV_X64_MSR_STAT_PAGES_AVAILABLE		(1 << 8)
>  
> +/* Frequency MSRs available */
> +#define HV_FEATURE_FREQUENCY_MSRS_AVAILABELE	(1 << 8)

s/AVAILABELE/AVAILABLE/ please

> +
>  /* Crash MSR available */
>  #define HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE (1 << 10)
>  
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 04cb8d3..250f432 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -194,7 +194,8 @@ static void __init ms_hyperv_init_platform(void)
>  	}
>  
>  #ifdef CONFIG_X86_LOCAL_APIC
> -	if (ms_hyperv.features & HV_X64_MSR_APIC_FREQUENCY_AVAILABLE) {
> +	if (ms_hyperv.features & HV_X64_ACCESS_FREQUENCY_MSRS &&
> +	    ms_hyperv.misc_features & HV_FEATURE_FREQUENCY_MSRS_AVAILABELE) {
>  		/*
>  		 * Get the APIC frequency.
>  		 */
> -- 
> 2.9.4
> 
>