linux-kernel - Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2343c662-f70d-1e76-d863-5f6bb66c269b@broadcom.com>
Date:   Tue, 20 Jun 2017 21:53:15 +0200
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        franky.lin@...adcom.com, hante.meuleman@...adcom.com,
        kvalo@...eaurora.org, rafal@...ecki.pl,
        pieter-paul.giesberts@...adcom.com
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] cfg80211: Fix a memory leak in error handling path in
 'brcmf_cfg80211_attach'



On 20-06-17 08:22, Christophe JAILLET wrote:
> If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error
> handling path to free it in such a case.

Thanks. Please add the following tags:

Cc: stable@...r.kernel.org
> Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload support")
Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)