linux-kernel - RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR07MB29434F09FBC054D2E0310D6FF3C50@MWHPR07MB2943.namprd07.prod.outlook.com>
Date:   Tue, 20 Jun 2017 20:15:34 +0000
From:   "Chickles, Derek" <Derek.Chickles@...ium.com>
To:     David Miller <davem@...emloft.net>,
        "dvlasenk@...hat.com" <dvlasenk@...hat.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>,
        "Kanneganti, Prasad" <Prasad.Kanneganti@...ium.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in
 .data

> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, June 20, 2017 12:22 PM
> 
> From: Denys Vlasenko <dvlasenk@...hat.com>
> Date: Mon, 19 Jun 2017 21:50:52 +0200
> 
> > Only compile-tested - I don't have the hardware.
> >
> > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
> > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
> > anyway.
> >
> > Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> 
> Looks good to me but I'll let one of the liquidio guys review this first
> before I apply it.

Felix is going to try this out this week to confirm. Let's wait for his ack.