linux-kernel - RE: [PATCH v3 2/3] gpio: Add support for TPS68470 GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6F87890CF0F5204F892DEA1EF0D77A59725C3299@FMSMSX114.amr.corp.intel.com>
Date:   Tue, 20 Jun 2017 22:16:59 +0000
From:   "Mani, Rajmohan" <rajmohan.mani@...el.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "ACPI Devel Maling List" <linux-acpi@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: RE: [PATCH v3 2/3] gpio: Add support for TPS68470 GPIOs

Hi Linus,

Thanks for your comments.

> On Mon, Jun 12, 2017 at 11:26 AM, Rajmohan Mani
> <rajmohan.mani@...el.com> wrote:
> 
> > This patch adds support for TPS68470 GPIOs.
> > There are 7 GPIOs and a few sensor related GPIOs.
> > These GPIOs can be requested and configured as appropriate.
> >
> > Signed-off-by: Rajmohan Mani <rajmohan.mani@...el.com>
> 
> This is some fine code.
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Feel free to merge this through MFD or tell me if I should merge it if there are
> no compile-time dependencies.

I still have the following 3 outstanding comments from Andy (that includes one from Lee) on this patch series.

Main points (some I already told in an answer to Sakari's mail):

1. Consider 2 GPIO chips over 1.(Andy on GPIO driver)
 I will look into this week and get back on the issue that I find with using 2 GPIO chips.

2. Fix FIXME(s) (Andy and Lee on MFD driver)
I will work on this once I am done with 1.

+	/* FIXME: configure these dynamically */
+	/* Enable Daisy Chain LDO and configure relevant GPIOs as output */
+	ret = regmap_write(regmap, TPS68470_REG_S_I2C_CTL, 2);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_write(regmap, TPS68470_REG_GPCTL4A, 2);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_write(regmap, TPS68470_REG_GPCTL5A, 2);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_write(regmap, TPS68470_REG_GPCTL6A, 2);
+	if (ret < 0)
+		return ret;
+
+	/*
+	 * When SDA and SCL are routed to GPIO1 and GPIO2, the mode
+	 * for these GPIOs must be configured using their respective
+	 * GPCTLxA registers as inputs with no pull-ups.
+	 */
+	ret = regmap_write(regmap, TPS68470_REG_GPCTL1A, 0);
+	if (ret < 0)
+		return ret;
+
+	ret = regmap_write(regmap, TPS68470_REG_GPCTL2A, 0);
+	if (ret < 0)
+		return ret;
+
+	/* Enable daisy chain */
+	ret = regmap_update_bits(regmap, TPS68470_REG_S_I2C_CTL, 1, 1);
+	if (ret < 0)
+		return ret;

3. Move <include/i2c.h> from tps68470.h to tps68470.c (Andy on MFD driver)
This is done, but waiting on 1 and 2

Thanks
Raj