linux-kernel - Re: [PATCH v2] drm/exynos/dsi: Remove error handling for bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <435f9640-379d-acfd-a445-50a2894a1259@samsung.com>
Date:   Tue, 20 Jun 2017 13:51:50 +0900
From:   Hoegeun Kwon <hoegeun.kwon@...sung.com>
To:     Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>,
        inki.dae@...sung.com, jy0922.shim@...sung.com,
        sw0312.kim@...sung.com, airlied@...ux.ie, kgene@...nel.org,
        krzk@...nel.org
Cc:     javier@....samsung.com, a.hajda@...sung.com,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hoegeun Kwon <hoegeun.kwon@...sung.com>
Subject: Re: [PATCH v2] drm/exynos/dsi: Remove error handling for
 bridge_node DT parsing

Hello Tobias,

Sorry for late reply.

On 06/14/2017 09:30 PM, Tobias Jakobi wrote:
> Hello Hoegeun,
>
> my last question (does this regress the case "node required, but
> absent") still stands.
>
>
> Hoegeun Kwon wrote:
>> Remove the error handling of bridge_node because the bridge_node is
>> required optionally.
> I don't think a construction like that exists. Either it's required, or
> it's optional. "required optionally" makes no sense to me (but I'm not a
> native speaker).
>
> - Tobias

The bridge_node is optional.
I will change commit message and send ver3 patch.

Best regards,
Hoegeun

>
>
>> For example, In case of Exynos SoC, a bridge device such as mDNIe and
>> MIC could be placed between Display Controller and MIPI DSI device but
>> the bridge device is required optionally.
>>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@...sung.com>
>> ---
>>
>> Hi Inki and Tobias,
>>
>> Thanks for your review.
>>
>> Changes for V2:
>> - Modified the commit message in more detail than before.
>>
>> Best Regards,
>> Hoegeun
>>
>>   drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> index a11b795..6ee0dac 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>>   		return ret;
>>   
>>   	dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>> -	if (!dsi->bridge_node)
>> -		return -EINVAL;
>>   
>>   	return 0;
>>   }
>>
>
>
>