linux-kernel - Re: [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87injra5wh.wl%kuninori.morimoto.gx@renesas.com>
Date:   Tue, 20 Jun 2017 00:01:42 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Colin King <colin.king@...onical.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        <alsa-devel@...a-project.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ASoC: rsnd: make main_rate signed to check for -ve error return codes


Hi Colin

> From: Colin Ian King <colin.king@...onical.com>
> 
> The comparison of main_rate < 0 has no effect because main_rate is
> an unsigned int. Make it signed so that any -ve error returns from the
> call to rsnd_clk_query can be detected.
> 
> Detected by CoverityScan, CID#1446152 ("Unsigned compared against 0")
> 
> Fixes: ef4cf5d6a143e0 ("ASoC: rsnd: add rsnd_ssi_clk_query()")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Thank you for your patch.
But, I posted this fixup patch (not yet accepted)

To: Mark Brown <broonie@...nel.org>, Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] ASoC: rsnd: fixup unsigned expression compared with zero: main_rate
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
CC: Linux-ALSA <alsa-devel@...a-project.org>, Simon <horms@...ge.net.au>,
 <linux-renesas-soc@...r.kernel.org>
Date: Fri, 16 Jun 2017 00:02:59 +0000

>  sound/soc/sh/rcar/ssi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
> index c8956c3484dd..d220512918f9 100644
> --- a/sound/soc/sh/rcar/ssi.c
> +++ b/sound/soc/sh/rcar/ssi.c
> @@ -258,7 +258,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
>  	struct rsnd_mod *ssi_parent_mod = rsnd_io_to_mod_ssip(io);
>  	int chan = rsnd_runtime_channel_for_ssi(io);
>  	int idx, ret;
> -	unsigned int main_rate;
> +	int main_rate;
>  	unsigned int rate = rsnd_io_is_play(io) ?
>  		rsnd_src_get_out_rate(priv, io) :
>  		rsnd_src_get_in_rate(priv, io);
> -- 
> 2.11.0
>