[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1497944521.16795.2.camel@redhat.com>
Date: Tue, 20 Jun 2017 09:42:01 +0200
From: Gerd Hoffmann <kraxel@...hat.com>
To: Daniel Vetter <daniel@...ll.ch>, Al Viro <viro@...iv.linux.org.uk>,
"Clark, Rob" <robdclark@...il.com>
Cc: linux-sparse@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: __user with scalar data types
Hi,
> Yep that's cargo-culted, but from a quick grep only msm and qxl
> headers do this (the other __user annotations in uapi/drm are for
> pointers, where it's correct). Adding those maintainers.
Yep, those looks pointless indeed.
> Also, if you use u64_to_user_ptr helper macro sparse should have
> caught this (if not we'd need to improve the macro).
And qxl should actually use it.
Fix attached (compile-tested only so far), does that look ok?
cheers,
Gerd
View attachment "qxlfix" of type "text/x-patch" (2828 bytes)
Powered by blists - more mailing lists