linux-kernel - Re: [PATCH 1/3] ARM: dts: sunxi: add R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170620085748.apv3wlehyllecb5q@flea.lan>
Date:   Tue, 20 Jun 2017 10:57:48 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Ziping Chen <techping.chan@...il.com>
Cc:     wens@...e.org, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH 1/3] ARM: dts: sunxi: add R_LRADC support for A83T

On Sun, Jun 18, 2017 at 09:00:16PM +0800, Ziping Chen wrote:
> From: Ziping Chen <techping.chan@...il.com>
> 
> The Allwinner A83T's R_LRADC is similiar with the
> Allwinner A10's LRADC, they can use the same driver.

There's a typo in similar above.

> Add support for it.
> 
> Signed-off-by: Ziping Chen <techping.chan@...il.com>
> ---
>  arch/arm/boot/dts/sun8i-a83t.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 8923ba625b76..ecc75bf6780e 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -301,5 +301,12 @@
>  			interrupt-controller;
>  			#interrupt-cells = <3>;
>  		};
> +
> +		r_lradc: lradc@...03c00 {
> +			compatible = "allwinner,sun4i-a10-lradc-keys";

Could you add an A83T specific compatible here?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)