linux-kernel - Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo52KMMt+S-KVYnmMy9qGUL6jMD2Uj8EJWNkKUQLr0_wfAw@mail.gmail.com>
Date:   Tue, 20 Jun 2017 11:57:11 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Inki Dae <inki.dae@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        David Airlie <airlied@...ux.ie>, Kukjin Kim <kgene@...nel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        LAKML <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/S5P EXYNOS AR..." 
        <linux-samsung-soc@...r.kernel.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        linux-fbdev <linux-fbdev@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 1/2] drm/exynos/decon: Add include guard to the Exynos7 header

On 20 June 2017 at 11:02, Krzysztof Kozlowski <krzk@...nel.org> wrote:
> On Tue, Jun 20, 2017 at 11:53 AM, Emil Velikov <emil.l.velikov@...il.com> wrote:
>> On 19 June 2017 at 17:31, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>> Although header is included only once but still having an include guard
>>> is a good practice.  To avoid confusion, add SoC prefix to existing
>>> Exynos5433 header include guard.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> ---
>>>  include/video/exynos5433_decon.h | 6 +++---
>>>  include/video/exynos7_decon.h    | 5 +++++
>>>  2 files changed, 8 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/include/video/exynos5433_decon.h b/include/video/exynos5433_decon.h
>>> index 78957c9626f5..b30362da5692 100644
>>> --- a/include/video/exynos5433_decon.h
>>> +++ b/include/video/exynos5433_decon.h
>>> @@ -6,8 +6,8 @@
>>>   * published by the Free Software Foundationr
>>>   */
>>>
>>> -#ifndef EXYNOS_REGS_DECON_H
>>> -#define EXYNOS_REGS_DECON_H
>>> +#ifndef EXYNOS5433_REGS_DECON_H
>>> +#define EXYNOS5433_REGS_DECON_H
>>>
>> Drop the _REGS_ part from the guard on each header? The file name/path
>> does not have it, plus it'll save some WTF moments when
>> exynos{5433,7}_regs_decon.h comes about.
>
> So maybe it makes sense to reorder these patches and use the guard
> name matching final file name?
>
That sounds better, IMHO.

-Emil