linux-kernel - [tip:sched/core] sched/core: Drop the unused try_get_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-f11cc0760b8397e0d230122606421b6a96e9f869@git.kernel.org>
Date:   Tue, 20 Jun 2017 06:27:25 -0700
From:   tip-bot for Davidlohr Bueso <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     torvalds@...ux-foundation.org, dave@...olabs.net, oleg@...hat.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de, dbueso@...e.de,
        mingo@...nel.org, peterz@...radead.org, hpa@...or.com
Subject: [tip:sched/core] sched/core: Drop the unused try_get_task_struct()
 helper function

Commit-ID:  f11cc0760b8397e0d230122606421b6a96e9f869
Gitweb:     http://git.kernel.org/tip/f11cc0760b8397e0d230122606421b6a96e9f869
Author:     Davidlohr Bueso <dave@...olabs.net>
AuthorDate: Wed, 14 Jun 2017 19:37:30 -0700
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 20 Jun 2017 12:48:37 +0200

sched/core: Drop the unused try_get_task_struct() helper function

This function was introduced by:

  150593bf8693 ("sched/api: Introduce task_rcu_dereference() and try_get_task_struct()")

... to allow easier usage of task_rcu_dereference(), however no users
were ever added. Drop the helper.

Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Oleg Nesterov <oleg@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: dave@...olabs.net
Link: http://lkml.kernel.org/r/20170615023730.22827-1-dave@stgolabs.net
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 include/linux/sched/task.h |  2 --
 kernel/exit.c              | 13 -------------
 2 files changed, 15 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index a978d71..f0f065c 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -95,8 +95,6 @@ static inline void put_task_struct(struct task_struct *t)
 }
 
 struct task_struct *task_rcu_dereference(struct task_struct **ptask);
-struct task_struct *try_get_task_struct(struct task_struct **ptask);
-
 
 #ifdef CONFIG_ARCH_WANTS_DYNAMIC_TASK_STRUCT
 extern int arch_task_struct_size __read_mostly;
diff --git a/kernel/exit.c b/kernel/exit.c
index 7d69443..c632262 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -318,19 +318,6 @@ void rcuwait_wake_up(struct rcuwait *w)
 	rcu_read_unlock();
 }
 
-struct task_struct *try_get_task_struct(struct task_struct **ptask)
-{
-	struct task_struct *task;
-
-	rcu_read_lock();
-	task = task_rcu_dereference(ptask);
-	if (task)
-		get_task_struct(task);
-	rcu_read_unlock();
-
-	return task;
-}
-
 /*
  * Determine if a process group is "orphaned", according to the POSIX
  * definition in 2.2.2.52.  Orphaned process groups are not to be affected