linux-kernel - Re: [PATCH] backlight: pwm_bl: make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001d2e9cd$624285e0$26c791a0$@gmail.com>
Date:   Tue, 20 Jun 2017 09:59:06 -0400
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'Daniel Thompson'" <daniel.thompson@...aro.org>,
        "'Arvind Yadav'" <arvind.yadav.cs@...il.com>,
        <thierry.reding@...il.com>, <lee.jones@...aro.org>,
        <b.zolnierkie@...sung.com>
Cc:     <linux-pwm@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] backlight: pwm_bl: make of_device_ids const

On Tuesday, June 20, 2017 6:53 AM, Daniel Thompson wrote:
> 
> On 20/06/17 08:52, Arvind Yadav wrote:
> > of_device_ids are not supposed to change at runtime. All functions
> > working with of_device_ids provided by <linux/of.h> work with const
> > of_device_ids. So mark the non-const structs as const.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> 
> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> 
> 
> > ---
> >   drivers/video/backlight/pwm_bl.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/pwm_bl.c
> b/drivers/video/backlight/pwm_bl.c
> > index 002f1ce..9bd1768 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
> >   	return 0;
> >   }
> >
> > -static struct of_device_id pwm_backlight_of_match[] = {
> > +static const struct of_device_id pwm_backlight_of_match[] = {
> >   	{ .compatible = "pwm-backlight" },
> >   	{ }
> >   };
> >