linux-kernel - Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Jun 2017 17:36:51 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Kumar Gala <galak@...eaurora.org>,
        Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        Nadav Haklai <nadavh@...vell.com>,
        Hanna Hawa <hannah@...vell.com>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Miquèl Raynal 
        <miquel.raynal@...e-electrons.com>
Subject: Re: [PATCH v4 6/6] arm64: dts: marvell: enable GICP and ICU on
 Armada 7K/8K

Hello,

On Tue, 20 Jun 2017 16:56:35 +0200, Gregory CLEMENT wrote:

> > +#include <dt-bindings/interrupt-controller/mvebu-icu.h>  
> 
> With this line you created a dependency with the patch "irqchip:
> irq-mvebu-icu: new driver for Marvell ICU". And without it the dtb is
> not buidable.
> 
> So either I wait for the next kernel release to apply it or I will need
> a stable branch with the commit adding the mvebu-icu.h file.

Alternatively, I could change the patch to use hardcoded values for now
(i.e replace ICU_GRP_NSR everywhere by 0x0), and then change it during
the next kernel cycle to use the #define value. I would really prefer
such a solution to a solution where merging the entire ICU DT change
would be delayed by one cycle.

Let me know what you prefer. Maybe Marc can say if the irqchip
maintainers can provide a stable branch containing the mvebu-icu.h file.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com