linux-kernel - Re: [PATCH v4 08/18] xen/pvcalls: implement connect command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd863110-cc9c-5535-887e-7126a88d62d7@oracle.com>
Date:   Tue, 20 Jun 2017 11:47:34 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xen.org
Cc:     linux-kernel@...r.kernel.org, jgross@...e.com,
        Stefano Stabellini <stefano@...reto.com>
Subject: Re: [PATCH v4 08/18] xen/pvcalls: implement connect command


>> +
>>  static int pvcalls_back_connect(struct xenbus_device *dev,
>>  				struct xen_pvcalls_request *req)
>>  {
>> +	struct pvcalls_fedata *fedata;
>> +	int ret = -EINVAL;
>> +	struct socket *sock;
>> +	struct sock_mapping *map;
>> +	struct xen_pvcalls_response *rsp;
>> +
>> +	fedata = dev_get_drvdata(&dev->dev);
>> +
>> +	ret = sock_create(AF_INET, SOCK_STREAM, 0, &sock);
>> +	if (ret < 0)
>> +		goto out;
>> +	ret = inet_stream_connect(sock, (struct sockaddr *)&req->u.connect.addr,
>> +				  req->u.connect.len, req->u.connect.flags);
>> +	if (ret < 0) {
>> +		sock_release(sock);
>> +		goto out;
>> +	}
>> +	
>> +	map = pvcalls_new_active_socket(fedata,
>> +					req->u.connect.id,
>> +					req->u.connect.ref,
>> +					req->u.connect.evtchn,
>> +					sock);
>> +	if (!map) {
>> +		sock_release(map->sock);
>> +		goto out;
> Unnecessary goto.

Oh, and also ret needs to be set since it will be cleared by
inet_stream_connect().

-boris


>
>> +	}
>> +
>> +out:
>> +	rsp = RING_GET_RESPONSE(&fedata->ring, fedata->ring.rsp_prod_pvt++);
>> +	rsp->req_id = req->req_id;
>> +	rsp->cmd = req->cmd;
>> +	rsp->u.connect.id = req->u.connect.id;
>> +	rsp->ret = ret;
>> +
>> +	return ret;
>