linux-kernel - Re: [PATCH 3/3] fsi/master-gpio: Add external mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XcVH19nYRP85T6rX1D3jd+1C4kr09DW3W_9kf1DJjj49Q@mail.gmail.com>
Date:   Wed, 21 Jun 2017 15:31:07 +0930
From:   Joel Stanley <joel@....id.au>
To:     Jeremy Kerr <jk@...abs.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christopher Bostic <cbostic@...ux.vnet.ibm.com>
Subject: Re: [PATCH 3/3] fsi/master-gpio: Add external mode

Hi Jeremy,

On Mon, Jun 19, 2017 at 6:56 PM, Jeremy Kerr <jk@...abs.org> wrote:
> This change introduces an 'external mode' for GPIO-based FSI masters,
> +static ssize_t external_mode_show(struct device *dev,
> +               struct device_attribute *attr, char *buf)
> +{
> +       struct fsi_master_gpio *master = dev_get_drvdata(dev);
> +
> +       return snprintf(buf, PAGE_SIZE - 1, "%u",

I gave this a spin on a machine today and noticed we're missing a
newline there. Should this be "%u\n"?

Cheers,

Joel

> +                       master->external_mode ? 1 : 0);
> +}
> +