linux-kernel - Re: [PATCH] drm: armada: make of_device_ids const.

Open Source and information security mailing list archives

Message-ID: <20170621070658.6kamcwsy25l6altm@phenom.ffwll.local>
Date:   Wed, 21 Jun 2017 09:06:58 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     linux@...linux.org.uk, airlied@...ux.ie,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: armada: make of_device_ids const.

On Tue, Jun 20, 2017 at 10:44:33AM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    8836	    744	      0	   9580	   256c	drivers/gpu/drm/armada/armada_crtc.o
> 
> File size after constify armada_lcd_of_match:
>    text	   data	    bss	    dec	    hex	filename
>    9220	    328	      0	   9548	   254c	drivers/gpu/drm/armada/armada_crtc.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied to drm-misc-next, thanks.
-Daniel

> ---
>  drivers/gpu/drm/armada/armada_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
> index 4fe19fd..94b76bd 100644
> --- a/drivers/gpu/drm/armada/armada_crtc.c
> +++ b/drivers/gpu/drm/armada/armada_crtc.c
> @@ -1364,7 +1364,7 @@ static int armada_lcd_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static struct of_device_id armada_lcd_of_match[] = {
> +static const struct of_device_id armada_lcd_of_match[] = {
>  	{
>  		.compatible	= "marvell,dove-lcd",
>  		.data		= &armada510_ops,
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives