linux-kernel - Re: [PATCH] drm/arm: hdlcd: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621081633.GB1322@e110455-lin.cambridge.arm.com>
Date:   Wed, 21 Jun 2017 09:16:34 +0100
From:   Liviu Dudau <liviu.dudau@....com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Brian Starkey <brian.starkey@....com>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/arm: hdlcd: remove unused variables

Hi Arnd,

On Tue, Jun 20, 2017 at 10:30:38PM +0200, Arnd Bergmann wrote:
> The last rework left behind two unused variables:
> 
> drm/arm/hdlcd_crtc.c: In function 'hdlcd_plane_atomic_update':
> drm/arm/hdlcd_crtc.c:264:13: warning: unused variable 'src_y' [-Wunused-variable]
> drm/arm/hdlcd_crtc.c:264:6: warning: unused variable 'src_x' [-Wunused-variable]
> 
> This removes them.

Thanks for the patch! Acked-by: Liviu Dudau <liviu.dudau@....com>

This is starting to get embarrassing :) I'm not sure why I didn't see the warnings when
I did my builds, but I would like to make changes so that in the future I can catch
situations like this. Do you change the flags of the default make multi_v7_defconfig?

I will apply the patch to the HLDCD tree and send Dave an updated pull request.

Best regards,
Liviu

> 
> Fixes: b2ae06ae9834 ("drm/arm: hdlcd: Use CMA helper for plane buffer address calculation")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/gpu/drm/arm/hdlcd_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_crtc.c b/drivers/gpu/drm/arm/hdlcd_crtc.c
> index 0128ebd318f5..d67b6f15e8b8 100644
> --- a/drivers/gpu/drm/arm/hdlcd_crtc.c
> +++ b/drivers/gpu/drm/arm/hdlcd_crtc.c
> @@ -261,7 +261,7 @@ static void hdlcd_plane_atomic_update(struct drm_plane *plane,
>  {
>  	struct drm_framebuffer *fb = plane->state->fb;
>  	struct hdlcd_drm_private *hdlcd;
> -	u32 src_x, src_y, dest_h;
> +	u32 dest_h;
>  	dma_addr_t scanout_start;
>  
>  	if (!fb)
> -- 
> 2.9.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯