linux-kernel - Re: [PATCH v2] perf: libdw support for powerpc [ping]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621013143.GB17392@stream.lan>
Date:   Wed, 21 Jun 2017 03:31:43 +0200
From:   Mark Wielaard <mark@...mp.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Milian Wolff <milian.wolff@...b.com>,
        Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-kernel@...r.kernel.org,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2] perf: libdw support for powerpc [ping]

On Tue, Jun 20, 2017 at 10:06:35PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jun 15, 2017 at 01:16:32PM +0200, Mark Wielaard escreveu:
> > On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote:
> > > Just a quick question: Have you guys applied my recent patch:
> > > 
> > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6
> > > Author: Milian Wolff <milian.wolff@...b.com>
> > > Date:   Thu Jun 1 23:00:21 2017 +0200
> > > 
> > >     perf report: Include partial stacks unwound with libdw
> > >     
> > >     So far the whole stack was thrown away when any error occurred before
> > >     the maximum stack depth was unwound. This is actually a very common
> > >     scenario though. The stacks that got unwound so far are still
> > >     interesting. This removes a large chunk of differences when comparing
> > >     perf script output for libunwind and libdw perf unwinding.
> > > 
> > > If not, then this could explain the issue you are seeing.
> > 
> > Thanks! No, I didn't have that patch (*) yet. It makes a huge
> > difference. With that, Paolo's patch and the elfutils libdw powerpc64
> > fallback unwinder patch, it looks like I get user stack traces for
> > everything now on ppc64le.
> 
> Can I take that as a Tested-by: you?

Sure.
Tested-by: Mark Wielaard <mark@...mp.org>

Thanks,

Mark