linux-kernel - Re: [PATCH v10 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFGCpxzJJGyhJWFe9J5f34e-etsF=0AC4+y9sKeVxWRD8L0tPw@mail.gmail.com>
Date:   Wed, 21 Jun 2017 20:47:45 +0800
From:   Guodong Xu <guodong.xu@...aro.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     Xiaowei Song <songxiaowei@...ilicon.com>, kbuild-all@...org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Suzhuangluan <suzhuangluan@...ilicon.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon
 Kirin SoC

On Mon, Jun 19, 2017 at 10:02 PM, kbuild test robot <lkp@...el.com> wrote:
> Hi Xiaowei,
>
> [auto build test ERROR on pci/next]
> [also build test ERROR on v4.12-rc5 next-20170619]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Xiaowei-Song/PCI-hisi-Add-DT-binding-for-PCIe-of-Kirin-SoC-series/20170619-194535
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
> config: arm64-defconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm64
>
> All errors (new ones prefixed by >>):


Thanks for the finding. Sorry about this.

v10 patchset should be ignored. Xiaowei sent v11 yesterday.

-Guodong

>
>    drivers/pci/dwc/pcie-kirin.c: In function 'kirin_pcie_establish_link':
>>> drivers/pci/dwc/pcie-kirin.c:424:12: error: 'dev' undeclared (first use in this function)
>        dev_err(dev, "Link Fail\n");
>                ^~~
>    drivers/pci/dwc/pcie-kirin.c:424:12: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +/dev +424 drivers/pci/dwc/pcie-kirin.c
>
>    418
>    419          /* check if the link is up or not */
>    420          while (!kirin_pcie_link_up(pci)) {
>    421                  usleep_range(LINK_WAIT_MIN, LINK_WAIT_MAX);
>    422                  count++;
>    423                  if (count == 1000) {
>  > 424                          dev_err(dev, "Link Fail\n");
>    425                          return -EINVAL;
>    426                  }
>    427          }
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation