lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Jun 2017 09:42:50 -0400 From: Don Zickus <dzickus@...hat.com> To: Arnd Bergmann <arnd@...db.de> Cc: Andrew Morton <akpm@...ux-foundation.org>, Ingo Molnar <mingo@...nel.org>, Babu Moger <babu.moger@...cle.com>, Nicholas Piggin <npiggin@...il.com>, Konstantin Khlebnikov <khlebnikov@...dex-team.ru>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] kernel/watchdog: hide unused function On Tue, Jun 20, 2017 at 10:48:44PM +0200, Arnd Bergmann wrote: > watchdog_update_cpus() is defined unconditionally, but only used when > CONFIG_SYSCTL is defined: > > kernel/watchdog.c:608:12: error: 'watchdog_update_cpus' defined but not used [-Werror=unused-function] > > This adds another #ifdef around it. Thanks! Acked-by: Don Zickus <dzickus@...hat.com> > > Fixes: mmotm ("kernel/watchdog: provide watchdog_nmi_reconfigure() for arch watchdogs") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > kernel/watchdog.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 06cd965f64d2..95361f9f3f40 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -605,11 +605,13 @@ static void watchdog_disable_all_cpus(void) > } > } > > +#ifdef CONFIG_SYSCTL > static int watchdog_update_cpus(void) > { > return smpboot_update_cpumask_percpu_thread( > &watchdog_threads, &watchdog_cpumask); > } > +#endif > > #else /* SOFTLOCKUP */ > static int watchdog_park_threads(void) > @@ -630,10 +632,12 @@ static void watchdog_disable_all_cpus(void) > { > } > > +#ifdef CONFIG_SYSCTL > static int watchdog_update_cpus(void) > { > return 0; > } > +#endif > > static void set_sample_period(void) > { > -- > 2.9.0 >
Powered by blists - more mailing lists