linux-kernel - Re: [PATCH] drm: sti: sti_hqvdp: undo preparation of a clock source.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+M3ks5nsqYbfGAMYsr2R_h6NmFW27VL05jw=tVxqU_CmEobKA@mail.gmail.com>
Date:   Wed, 21 Jun 2017 15:55:06 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: sti: sti_hqvdp: undo preparation of a clock source.

2017-06-21 12:15 GMT+02:00 Arvind Yadav <arvind.yadav.cs@...il.com>:
> Undo preparation of a clock source, if sti_hqvdp_start_xp70 and
> sti_hqvdp_atomic_check are not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied on drm-misc-next, thanks,

Benjamin

> ---
>  drivers/gpu/drm/sti/sti_hqvdp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 075802d..8dbb34d 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -959,6 +959,7 @@ static void sti_hqvdp_start_xp70(struct sti_hqvdp *hqvdp)
>         }
>         if (i == POLL_MAX_ATTEMPT) {
>                 DRM_ERROR("Could not reset\n");
> +               clk_disable_unprepare(hqvdp->clk);
>                 goto out;
>         }
>
> @@ -995,6 +996,7 @@ static void sti_hqvdp_start_xp70(struct sti_hqvdp *hqvdp)
>         }
>         if (i == POLL_MAX_ATTEMPT) {
>                 DRM_ERROR("Could not boot\n");
> +               clk_disable_unprepare(hqvdp->clk);
>                 goto out;
>         }
>
> @@ -1082,6 +1084,7 @@ static int sti_hqvdp_atomic_check(struct drm_plane *drm_plane,
>                                             &hqvdp->vtg_nb,
>                                             crtc)) {
>                         DRM_ERROR("Cannot register VTG notifier\n");
> +                       clk_disable_unprepare(hqvdp->clk_pix_main);
>                         return -EINVAL;
>                 }
>                 hqvdp->vtg_registered = true;
> --
> 1.9.1