linux-kernel - Re: [net-next PATCH] tcp: md5: hide unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170621.112000.1689554856831469695.davem@davemloft.net>
Date:   Wed, 21 Jun 2017 11:20:00 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, colona@...sta.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [net-next PATCH] tcp: md5: hide unused variable

From: Arnd Bergmann <arnd@...db.de>
Date: Tue, 20 Jun 2017 22:11:21 +0200

> Changing from a memcpy to per-member comparison left the
> size variable unused:
> 
> net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup':
> net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable]
> 
> This does not show up when CONFIG_IPV6 is enabled, but the
> variable can be removed either way, along with the now unused
> assignment.
> 
> Fixes: 6797318e623d ("tcp: md5: add an address prefix for key lookup")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks.