linux-kernel - Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <012614df-191c-5114-2961-615a7a5ca520@axentia.se>
Date:   Wed, 21 Jun 2017 18:36:17 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Peter Rosin <peda@...ator.liu.se>
Cc:     linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: atmel-hlcdc: sama5d4 does not have overlay2

On 2017-06-21 17:14, Nicolas Ferre wrote:
> On 16/06/2017 at 00:40, Peter Rosin wrote:
>> On 2017-06-15 11:37, Boris Brezillon wrote:
>>> On Thu, 15 Jun 2017 11:24:13 +0200
>>> Peter Rosin <peda@...ator.liu.se> wrote:
>>>
>>>> From: Peter Rosin <peda@...ntia.se>
>>>>
>>>> Remove the layer.
>>>
>>> Duh. It was present in the datasheet I had. Just downloaded last
>>> version of the datasheet and it's no longer there.
>>
>> Heh.
>>
>>> Nicolas, there's still a reference to OVR2 in the block diagram
>>> (Section "31.3 Block Diagram"), can ask fix that (or ask someone who
>>> can).
>>
>> Also, on page 2 (the Features chapter under peripherals) there's:
>>
>>    "LCD TFT Controller with 4 overlays..."
>>
>> I think it should be three?
> 
> Hi Peter and Boris,
> 
> After checking with the designers here, it seems that it's an issue with
> the latest datasheet. This is why Boris implemented it some time ago.
> 
> So, the conclusion is: the OVR2 was removed from latest sama5d4
> documentation by mistake. It will be corrected in next datasheet release.
> The OVR2 exists and works correctly on sama5d4.
> 
> So, please don't remove this layer ;-)

Right :-)

I assume the CLUT offset for overlay 2 is at 0xe00, just as it is for
sama5d3? When I know for sure, I can send a v5 of the other patch.

> Peter, thanks a lot for your work with supporting the CLUT feature!

I needed to get rid of some memory load...

Cheers,
peda