linux-kernel - Re: [GIT PULL] NTB bug fixes for v4.12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFxdun0-H13L+KCQ-Gn5kVAiyth=a+6NBcwcH5Ff8kHCcQ@mail.gmail.com>
Date:   Wed, 21 Jun 2017 12:05:50 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jon Mason <jdmason@...zu.us>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-ntb@...glegroups.com
Subject: Re: [GIT PULL] NTB bug fixes for v4.12

On Tue, Jun 20, 2017 at 7:59 AM, Jon Mason <jdmason@...zu.us> wrote:
>
> This was in my ntb branch since June 9th.  Previously, it was based on
> v4.12-rc4.  Immediately prior to doing the pull request, I did a
> rebase to rc6 to avoid any potential issues you might have applying
> them.

Please don't do that.

There are valid reasons for rebasing, but "just because" is not one of
them. The valid reasons are things like "I noticed that a completely
broken patch had made it into my queue, so I rebased to remove it" or
similar.

One common theme for valid reasons tends to be "..and I needed to
rerun all the testing", so in general I get very suspicious if things
are very recent, because clearly they didn't get very well tested.

                  Linus