linux-kernel - Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170621202423.26515ac7@kernel.org>
Date:   Wed, 21 Jun 2017 20:24:23 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     "Andrew F. Davis" <afd@...com>
Cc:     "Brüns, Stefan" <Stefan.Bruens@...h-aachen.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH v2 3/3] iio: adc: Fix polling of INA219 conversion ready
 flag

On Mon, 19 Jun 2017 13:30:31 -0500
"Andrew F. Davis" <afd@...com> wrote:

> On 06/19/2017 01:24 PM, Brüns, Stefan wrote:
> > On Mittwoch, 24. Mai 2017 21:56:54 CEST Jonathan Cameron wrote:  
> >> On Wed, 24 May 2017 20:53:35 +0100
> >>
> >> Jonathan Cameron <jic23@...nel.org> wrote:  
> >>> On Wed, 24 May 2017 02:09:07 +0200
> >>>
> >>> Stefan Brüns <stefan.bruens@...h-aachen.de> wrote:  
> >>>> While the INA226 has a conversion ready flag (CVRF) in the R/W
> >>>> Mask/Enable
> >>>> register with read-to-clear semantics, the corresponding bit of the
> >>>> INA219
> >>>> (CNVR) is part of the bus voltage register. The flag is cleared by
> >>>> reading
> >>>> the power register.
> >>>>
> >>>> Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de>  
> >>>
> >>> Again, looks good to me, but I would like input form Marc or Andrew
> >>> who are more familiar with these devices than me!
> >>>
> >>> Ping me in a week or two if nothing is happening and I look to have
> >>> lost these!  
> >>
> >> Ah Marc's old email is bouncing.  If no one has a more up to
> >> data address I guess we'll be looking at Andrew to have a chance to
> >> respond (which is more likely if I actually cc him ;)  
> > 
> > Ping ;-)
> >   
> 
> As for me, my silence is approval, nothing looks incorrect to me.
Applied to the togreg branch of iio.git and pushed out as testing.
It's late enough in the cycle that any fixes will probably be post
merge window now.  Also this doesn't apply to my fixes-togreg branch
(presumably due to the earlier patches).

Thanks for the ping.

Jonathan
> 
> > Kind regards,
> > 
> > Stefan
> >   
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html