linux-kernel - Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170621.152541.1977800544203723274.davem@davemloft.net>
Date:   Wed, 21 Jun 2017 15:25:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     joe@...ches.com
Cc:     dvlasenk@...hat.com, linux-kernel@...r.kernel.org,
        vyasevich@...il.com, nhorman@...driver.com,
        linux-sctp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner,
 save 1616 bytes

From: Joe Perches <joe@...ches.com>
Date: Wed, 21 Jun 2017 12:19:10 -0700

> On Wed, 2017-06-21 at 18:28 +0200, Denys Vlasenko wrote:
>> This function compiles to 147 bytes of machine code. 13 callsites.
>> 
>> I'm no expert on SCTP events, but quick reading of SCTP docs tells me that
>> SCTP events are not happening on every packet.
>> They are ASSOC_CHANGE, PEER_ADDR_CHANGE, REMOTE_ERROR and such.
>> Does not look performance critical.
> 
> Thanks.
> 
> But:
> 
>> diff --git a/net/sctp/ulpevent.c b/net/sctp/ulpevent.c
> []
>> @@ -88,7 +88,7 @@ int sctp_ulpevent_is_notification(const struct sctp_ulpevent *event)
>>  /* Hold the association in case the msg_name needs read out of
>>   * the association.
>>   */
>> -static inline void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
>> +static void sctp_ulpevent_set_owner(struct sctp_ulpevent *event,
>>  					   const struct sctp_association *asoc)
>>  {
>>  	struct sctp_chunk *chunk = event->chunk;
> 
> This now misaligns the next line after the inline removal.

Agreed, the argument indenation must be fixed.