linux-kernel - RE: [PATCH] x86/mce: Always save severity in machine_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR1201MB01311ABBD1224F32FC6AFB22F8DA0@BN6PR1201MB0131.namprd12.prod.outlook.com>
Date:   Wed, 21 Jun 2017 19:41:53 +0000
From:   "Ghannam, Yazen" <Yazen.Ghannam@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86/mce: Always save severity in machine_check_poll

> -----Original Message-----
> From: Borislav Petkov [mailto:bp@...en8.de]
> Sent: Monday, June 19, 2017 12:49 PM
> To: Ghannam, Yazen <Yazen.Ghannam@....com>
> Cc: linux-edac@...r.kernel.org; Tony Luck <tony.luck@...el.com>;
> x86@...nel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] x86/mce: Always save severity in machine_check_poll
> 
> 
> Just forget the work scheduling - it is only a marginal implementation thing -
> you only want to say that we want to log the severity since we already have it.
> And the most important aspect in your v2 commit message is explaining
> *why* we want the severity. And yes, it is possible to simply say, this is a
> cleanup and we can just as well always save it because it is a valid reason. And
> it makes sense too.
> 
> All I'm trying to remind you of, is, you should explain in your commit message
> what the issue is and *why* you're doing the change. When the first sentence
> of your commit message is "Remove code that was used to decide whether to
> schedule work." I'm starting to scratch my head, wondering, what the actual
> problem is and what you're trying to fix.
> 
> Ok?
> 

Yep, got it.

Thanks,
Yazen