linux-kernel - Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170621043513.GN3016@linux-l9pv.suse>
Date:   Wed, 21 Jun 2017 12:35:13 +0800
From:   joeyli <jlee@...e.com>
To:     Darren Hart <dvhart@...radead.org>
Cc:     Pali Rohár <pali.rohar@...il.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "Lee, Chun-Yi" <joeyli.kernel@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH] acer-wmi: Using zero as the first WMI instance number

On Tue, Jun 20, 2017 at 02:45:56PM -0700, Darren Hart wrote:
> On Tue, Jun 20, 2017 at 10:46:12PM +0200, Pali Rohár wrote:
> > On Tuesday 20 June 2017 19:22:46 Andy Shevchenko wrote:
> > > On Tue, Jun 20, 2017 at 7:48 PM, Pali Rohár <pali.rohar@...il.com>
> > > wrote:
> > > > On Tuesday 20 June 2017 17:06:23 Lee, Chun-Yi wrote:
> > > >> Pali Rohár found that there have some wmi query/evaluation
> > > >> code that they used 'one' as the first WMI instance number.
> > > >> But the number is indexed from zero that it's must less than
> > > >> the instance_count in _WDG.
> > > >> 
> > > >> This patch changes those instance number from one to zero.
> > > >> 
> > > >> Cc: Darren Hart <dvhart@...radead.org>
> > > >> Cc: Andy Shevchenko <andy@...radead.org>
> > > >> Cc: Pali Rohár <pali.rohar@...il.com>
> > > >> Signed-off-by: "Lee, Chun-Yi" <jlee@...e.com>
> > > > 
> > > > Looks good, Reviewed-by: Pali Rohár <pali.rohar@...il.com>
> > > 
> > > Unfortunately patchwork ignores this tag.
> > > So, in the future please:
> > > - put a tag on a separate line
> > > - do _not_ prepend it by any characters including white spaces
> > > (except new line :-) )

I see! I will also follow the rules in the future.

> > 
> > I have not known that those lines are parsed automatically.
> > Will do it in future!
> 
> :-) Thanks!
> 
> For reference, Patchwork tally's such things in the patch list view:
> https://patchwork.kernel.org/project/platform-driver-x86/list/
> 
> And, selfishly, the more normalized these are, the less likely Andy and I are to
> make mistakes manipulating them into the patches.
>

Joey Lee