linux-kernel - Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170621215053.GH4493@codeaurora.org>
Date:   Wed, 21 Jun 2017 14:50:53 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Tero Kristo <t-kristo@...com>, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: keystone: TI_SCI_PROTOCOL is needed for clk driver

On 06/20, Arnd Bergmann wrote:
> CONFIG_COMPILE_TEST allows building a configuration without
> TI_SCI_PROTOCOL, which then fails to link:
> 
> drivers/clk/keystone/sci-clk.o: In function `ti_sci_clk_probe':
> sci-clk.c:(.text.ti_sci_clk_probe+0x4c): undefined reference to `devm_ti_sci_get_handle'
> 
> This makes it a hard dependency. Right now, that means we can't
> actually compile-test the driver unless ARCH_KEYSTONE is set as
> well, but we can fix that by allowing TI_MESSAGE_MANAGER to
> be selected for COMPILE_TEST as well.
> 
> Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 

Looks ok to me. Tero?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project