linux-kernel - Re: [PATCH] Convert BUG_ON to WARN_ON in bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170621.175651.854625612625047729.davem@davemloft.net>
Date:   Wed, 21 Jun 2017 17:56:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     michael.j.dilmore@...il.com
Cc:     jay.vosburgh@...onical.com, vfalico@...il.com, andy@...yhouse.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        joe@...ches.com
Subject: Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

From: Michael D <michael.j.dilmore@...il.com>
Date: Wed, 21 Jun 2017 22:41:07 +0100

> I don't think you can stop it being dereferenced... you just need to
> prevent an attacker from exploiting the null pointer dereference
> vulnerability right? And this is done by returning the function right
> away?

What's all of this about an "attacker"?

If there is a bug, we dererence a NULL pointer, and we should
fix that bug.

The BUG_ON() helps us see where the problem is while at the
same time stopping the kernel before the NULL deref happens.