linux-kernel - Re: [lkp-robot] [mm] 1be7107fbe: kernel_BUG_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jun 2017 15:19:36 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Hugh Dickins <hughd@...gle.com>,
        kernel test robot <xiaolong.ye@...el.com>,
        Michal Hocko <mhocko@...e.com>,
        LKML <linux-kernel@...r.kernel.org>, LKP <lkp@...org>
Subject: Re: [lkp-robot] [mm] 1be7107fbe: kernel_BUG_at_mm/mmap.c

On Wed, Jun 21, 2017 at 1:56 PM, Oleg Nesterov <oleg@...hat.com> wrote:
>
> I understand. My point is that this check was invalidated by stack-guard-page
> a long ago, and this means that we add the user-visible change now.

Yeah. I guess we could consider it an *old* regression that got fixed,
but if people started relying on the regression...

>> Do you have a pointer to the report for this regression? I must have missed it.
>
> See http://marc.info/?t=149794523000001&r=1&w=2

Ok.

And thinking about it, while that is a silly test-case, the notion of
"create top-down segment, then start populating it _before_ moving the
stack pointer into it" is actually perfectly valid.

So I guess checking against the stack pointer is wrong in that case -
at least if the stack pointer isn't inside that vma to begin with.

So yes, removing that check looks like the right thing to do for now.

Do you want to send me the patch if you already have a commit message etc?

                    Linus