linux-kernel - Re: [PATCH] rcu: remove unused variable in boot_cpu_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622075910.mahc5gzrz5cxdsg6@gmail.com>
Date:   Thu, 22 Jun 2017 09:59:10 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rcu: remove unused variable in boot_cpu_state_init

So, to continue this side thought about uninitialized_var(), it is dangerous 
because the following buggy pattern does not generate a compiler warning:

        long uninitialized_var(error);

	...

        if (error)
                return error;

... and still there are over 290 uses of uninitialized_var() in the kernel - and 
any of them could turn into a silent but real uninitialized variable bugs due to 
subsequent changes.

Thanks,

	Ingo