linux-kernel - Re: [PATCH] Moved module init-functions into the module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170622080915.GA2936@steve.org.uk>
Date:   Thu, 22 Jun 2017 08:09:15 +0000
From:   Steve Kemp <steve@...ve.org.uk>
To:     Ethan Zhao <ethan.kernel@...il.com>
Cc:     Steve Kemp <steve@...ve.fi>, linux-security-module@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        James Morris <james.l.morris@...cle.com>,
        "Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH] Moved module init-functions into the module.

On Thu Jun 22, 2017 at 16:02:30 +0800, Ethan Zhao wrote:

>       Seems you moved the initialization of security module to
> late_initcall stage, that is not right.

  Thanks for the feedback.

>       For security modules, you should use security_initcall() macro to define
> the init functions.

  Literally just a change like this?

  -late_initcall(yama_add_hooks);
  +security_initcall(yama_add_hooks);

  I'll submit v2 with that shortly, thanks.

Steve
--