linux-kernel - Re: [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATqQt99-ryCE5ec=LwExTAN8jbh8FBYbjr15D71y79ZXg@mail.gmail.com>
Date:   Thu, 22 Jun 2017 10:19:35 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>,
        Michal Marek <mmarek@...e.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Grant Grundler <grundler@...omium.org>,
        Greg Hackmann <ghackmann@...gle.com>,
        Michael Davidson <md@...gle.com>
Subject: Re: [PATCH 1/2] kbuild: clang: Disable 'address-of-packed-member' warning

2017-05-17 6:32 GMT+09:00 Doug Anderson <dianders@...omium.org>:
> Hi,
>
> On Fri, Apr 21, 2017 at 2:39 PM, Matthias Kaehlcke <mka@...omium.org> wrote:
>> clang generates plenty of these warnings in different parts of the code,
>> to an extent that the warnings are little more than noise. Disable the
>> 'address-of-packed-member' warning.
>>
>> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 5039b9148d15..df5abf346354 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -703,6 +703,7 @@ KBUILD_CPPFLAGS += $(call cc-option,-Wno-unknown-warning-option,)
>>  KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
>>  KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
>>  KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
>> +KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
>>  # Quiet clang warning: comparison of unsigned expression < 0 is always false
>>  KBUILD_CFLAGS += $(call cc-disable-warning, tautological-compare)
>>  # CLANG uses a _MergedGlobals as optimization, but this breaks modpost, as the
>
> Though I'm no expert, after reading the discussion on this thread and
> looking at the examples provided by Matthias, this seems sane to me.
> Thus, FWIW:
>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>


1/2 applied to linux-kbuild/kbuild.  Thanks!


-- 
Best Regards
Masahiro Yamada