linux-kernel - Re: [PATCH] kbuild: deprecate cc-option-align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622085938.upkoiqqmurzq6nav@gmail.com>
Date:   Thu, 22 Jun 2017 10:59:38 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org, Matthias Kaehlcke <mka@...omium.org>,
        Marcin Nowakowski <marcin.nowakowski@...tec.com>,
        Arnd Bergmann <arnd@...db.de>,
        Mark Charlebois <charlebm@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Michal Marek <mmarek@...e.com>, linux-kernel@...r.kernel.org,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Jonathan Corbet <corbet@....net>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-doc@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>,
        Ingo Molnar <mingo@...hat.com>,
        Emese Revfy <re.emese@...il.com>
Subject: Re: [PATCH] kbuild: deprecate cc-option-align


* Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> Documentation/kbuild/makefiles.txt says the change for align options
> occurred at GCC 3.0, and Documentation/process/changes.rst says the
> minimal supported GCC version is 3.2, so it should be safe to hard-code
> -falign* options.
> 
> Fix the only user arch/x86/Makefile_32.cpu and deprecate the
> cc-option-align.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> x86 maintainers,
> 
> If this patch looks OK, could you give me Acked-by?

LGTM in principle, although I haven't tested it:

   Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo