linux-kernel - Re: [PATCH] x86/microcode/intel: make pointer intel_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170622090513.juhp6tqhl2phap3g@pd.tnic>
Date:   Thu, 22 Jun 2017 11:05:13 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/microcode/intel: make pointer intel_ucode_patch
 static

On Thu, Jun 22, 2017 at 09:49:40AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer intel_ucode_patch does not need to be in global scope,
> so make it static.
> 
> Cleans up sparse warning:
> "symbol 'intel_ucode_patch' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index d525a0bd7d28..59edbe9d4ccb 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -42,7 +42,7 @@
>  static const char ucode_path[] = "kernel/x86/microcode/GenuineIntel.bin";
>  
>  /* Current microcode patch used in early patching on the APs. */
> -struct microcode_intel *intel_ucode_patch;
> +static struct microcode_intel *intel_ucode_patch;
>  
>  static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
>  					unsigned int s2, unsigned int p2)
> -- 

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.