linux-kernel - Re: [PATCH] x86/microcode/AMD: make function __load_ucode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170622091826.cflexlzouzvov7l7@pd.tnic>
Date:   Thu, 22 Jun 2017 11:18:27 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/microcode/AMD: make function __load_ucode_amd static

On Thu, Jun 22, 2017 at 10:16:26AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The helper function __load_ucode_amd does not need to be in global
> scope, so make it static.
> 
> Cleans up sparse warning:
> "symbol '__load_ucode_amd' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> index e9f4d762aa5b..21b185793c80 100644
> --- a/arch/x86/kernel/cpu/microcode/amd.c
> +++ b/arch/x86/kernel/cpu/microcode/amd.c
> @@ -251,7 +251,7 @@ static bool get_builtin_microcode(struct cpio_data *cp, unsigned int family)
>  #endif
>  }
>  
> -void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
> +static void __load_ucode_amd(unsigned int cpuid_1_eax, struct cpio_data *ret)
>  {
>  	struct ucode_cpu_info *uci;
>  	struct cpio_data cp;
> -- 

Please merge all patches making symbols static in the microcode loader,
into a single patch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.