linux-kernel - Re: [PATCH] rtc: ds3232: add temperature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 09:29:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Kirill Esipov <yesipov@...il.com>
Cc:     kbuild-all@...org, a.zummo@...ertech.it,
        alexandre.belloni@...e-electrons.com, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kirill Esipov <yesipov@...il.com>
Subject: Re: [PATCH] rtc: ds3232: add temperature support

Hi Kirill,

[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on v4.12-rc6 next-20170621]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kirill-Esipov/rtc-ds3232-add-temperature-support/20170622-065247
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: x86_64-randconfig-h0-06220808 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/rtc/rtc-ds3232.c: In function 'ds3232_probe':
>> drivers/rtc/rtc-ds3232.c:451:24: warning: passing argument 1 of 'ds3232_hwmon_register' from incompatible pointer type
     ds3232_hwmon_register(dev, name);
                           ^
   drivers/rtc/rtc-ds3232.c:354:13: note: expected 'struct ds3232 *' but argument is of type 'struct device *'
    static void ds3232_hwmon_register(struct ds3232 *ds3232)
                ^
   drivers/rtc/rtc-ds3232.c:451:2: error: too many arguments to function 'ds3232_hwmon_register'
     ds3232_hwmon_register(dev, name);
     ^
   drivers/rtc/rtc-ds3232.c:354:13: note: declared here
    static void ds3232_hwmon_register(struct ds3232 *ds3232)
                ^

vim +/ds3232_hwmon_register +451 drivers/rtc/rtc-ds3232.c

   435		ds3232 = devm_kzalloc(dev, sizeof(*ds3232), GFP_KERNEL);
   436		if (!ds3232)
   437			return -ENOMEM;
   438	
   439		ds3232->regmap = regmap;
   440		ds3232->irq = irq;
   441		ds3232->dev = dev;
   442		dev_set_drvdata(dev, ds3232);
   443	
   444		ret = ds3232_check_rtc_status(dev);
   445		if (ret)
   446			return ret;
   447	
   448		if (ds3232->irq > 0)
   449			device_init_wakeup(dev, 1);
   450	
 > 451		ds3232_hwmon_register(dev, name);
   452	
   453		ds3232->rtc = devm_rtc_device_register(dev, name, &ds3232_rtc_ops,
   454							THIS_MODULE);
   455		if (IS_ERR(ds3232->rtc))
   456			return PTR_ERR(ds3232->rtc);
   457	
   458		if (ds3232->irq > 0) {
   459			ret = devm_request_threaded_irq(dev, ds3232->irq, NULL,

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (20328 bytes)