lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jun 2017 18:16:39 +0800 From: Chunyan Zhang <zhang.lyra@...il.com> To: Stephen Boyd <sboyd@...eaurora.org> Cc: Chunyan Zhang <chunyan.zhang@...eadtrum.com>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, linux-clk@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>, Xiaolong Zhang <xiaolong.zhang@...eadtrum.com>, Orson Zhai <orson.zhai@...eadtrum.com>, Geng Ren <geng.ren@...eadtrum.com>, Ben Li <ben.li@...eadtrum.com> Subject: Re: [PATCH V1 3/9] clk: sprd: add gate clock support On 20 June 2017 at 09:31, Stephen Boyd <sboyd@...eaurora.org> wrote: > On 06/18, Chunyan Zhang wrote: >> diff --git a/drivers/clk/sprd/Makefile b/drivers/clk/sprd/Makefile >> index 8f802b2..333e2b2 100644 >> --- a/drivers/clk/sprd/Makefile >> +++ b/drivers/clk/sprd/Makefile >> @@ -1,3 +1,3 @@ >> ifneq ($(CONFIG_OF),) >> -obj-y += ccu_common.o >> +obj-y += ccu_common.o ccu_gate.o > > Can this be built as a module? Since most of all Spreadtrum device drivers would depend on if clocks have been initialized, so we'd prefer to build this into the kernel image. > >> endif >> diff --git a/drivers/clk/sprd/ccu_gate.c b/drivers/clk/sprd/ccu_gate.c >> new file mode 100644 >> index 0000000..3d27615 >> --- /dev/null >> +++ b/drivers/clk/sprd/ccu_gate.c >> @@ -0,0 +1,102 @@ >> +/* >> + * Spreadtrum gate clock driver >> + * >> + * Copyright (C) 2017 Spreadtrum, Inc. >> + * >> + * SPDX-License-Identifier: GPL-2.0 >> + */ >> + >> +#include <linux/clk-provider.h> >> + >> +#include "ccu_gate.h" >> + >> +DEFINE_SPINLOCK(gate_lock); > > This variable name is not very unique for debugging lockdep > reports. Probably needs 'sprd' in the name. Ok. Thank you for your comments, Chunyan > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project
Powered by blists - more mailing lists