linux-kernel - Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1498134180.24295.2.camel@perches.com>
Date:   Thu, 22 Jun 2017 05:23:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, idryomov@...il.com,
        sage@...hat.com, elder@...nel.org
Cc:     ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: rbd: constify rbd_attr_group and rbd_opts_tokens

On Thu, 2017-06-22 at 17:34 +0530, Arvind Yadav wrote:
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   43100	   2161	     64	  45325	   b10d	drivers/block/rbd.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   43292	   1969	     64	  45325	   b10d	drivers/block/rbd.o

If you are going to do these conversions, I still think
it'd be better to use a standard struct declaration.

>From 2011, (const was also added)
http://lkml.iu.edu/hypermail/linux/kernel/1104.2/00738.html