linux-kernel - Re: [PATCH] mm: larger stack guard gap, between vmas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1498136291.2655.24.camel@decadent.org.uk>
Date:   Thu, 22 Jun 2017 13:58:11 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Willy Tarreau <w@....eu>
Cc:     Hugh Dickins <hughd@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Michal Hocko <mhocko@...nel.org>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Rik van Riel <riel@...hat.com>,
        Larry Woodman <lwoodman@...hat.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Tony Luck <tony.luck@...el.com>,
        "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Helge Diller <deller@....de>,
        James Hogan <james.hogan@...tec.com>,
        Laura Abbott <labbott@...hat.com>, Greg KH <greg@...ah.com>,
        security@...nel.org, linux-distros@...openwall.org, qsa@...lys.com,
        stable <stable@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote:
> On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote:
> > Here's my attempt at a backport to 3.2.  This is only tested on
> > x86_64 and I think I should introduce local variables for
> > vma_start_gap() in a few places.  I had to cherry-pick commit
> > 09884964335e "mm: do not grow the stack vma just because of an overrun
> > on preceding vma" before this one (which was a clean cherry-pick).
> 
> Ben, I can't apply it on top of 3.2.89 + the patch above, do you have
> any other patch in your local branch ? For example the patch tries to
> modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one
> I'm having here ends at line 159.

Sorry, yes, I did this on top of the Debian 3.2 branch and that *does*
have a patch to arch/arm/mm/mmap.c that I had forgotten about (commit
7dbaa466780a "ARM: 7169/1: topdown mmap support").  I think you can
just drop the changes in ARM's arch_get_unmapped_area_topdown().

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)