linux-kernel - Re: [PATCH] ASoC: es8316: add I2C dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD8Lp47tkPWKApp9ufMmtekgoL+Y_7u6E+o0XV6d5pJ5yx5vCA@mail.gmail.com>
Date:   Thu, 22 Jun 2017 07:14:46 -0600
From:   Daniel Drake <drake@...lessm.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mark Brown <broonie@...nel.org>,
        David Yang <yangxiaohua@...rest-semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        alsa-devel@...a-project.org,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: es8316: add I2C dependency

On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann <arnd@...db.de> wrote:
> Without CONFIG_I2C, we get a build failure:
>
> sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
> sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
>
> This adds the required Kconfig dependency.
>
> Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Daniel Drake <drake@...lessm.com>

Thanks for the patch.

> ---
>  sound/soc/codecs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c6286e5ba511..f0f794186186 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -546,6 +546,7 @@ config SND_SOC_ES7134
>
>  config SND_SOC_ES8316
>         tristate "Everest Semi ES8316 CODEC"
> +       depends on I2C
>
>  config SND_SOC_ES8328
>         tristate
> --
> 2.9.0
>