linux-kernel - Re: [PATCH 21/32] ext4: modify ext4_xattr_ino

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622142804.trfy3ce6wibh5amx@thunk.org>
Date:   Thu, 22 Jun 2017 10:28:04 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/32] ext4: modify ext4_xattr_ino_array to hold struct
 inode *

On Wed, Jun 21, 2017 at 02:21:31PM -0700, Tahsin Erdogan wrote:
> Tracking struct inode * rather than the inode number eliminates the
> repeated ext4_xattr_inode_iget() call later. The second call cannot
> fail in practice but still requires explanation when it wants to ignore
> the return value. Avoid the trouble and make things simple.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Added to the ext4 patch queue, thanks.

      	     	  	       - Ted