linux-kernel - Re: [PATCH 31/32] ext4: strong binding of xattr inode references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622155424.jj6c3fglp3vehddq@thunk.org>
Date:   Thu, 22 Jun 2017 11:54:24 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 31/32] ext4: strong binding of xattr inode references

On Wed, Jun 21, 2017 at 06:49:38PM -0700, Tahsin Erdogan wrote:
> To verify that a xattr entry is not pointing to the wrong xattr inode,
> we currently check that the target inode has EXT4_EA_INODE_FL flag set and
> also the entry size matches the target inode size.
> 
> For stronger validation, also incorporate crc32c hash of the value into
> the e_hash field. This is done regardless of whether the entry lives in
> the inode body or external attribute block.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Added to the ext4 patch queue, thanks.

					- Ted