linux-kernel - Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Jun 2017 21:51:10 +0530
From:   Ganapatrao Kulkarni <gpkulkarni@...il.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     "Moore, Robert" <robert.moore@...el.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>,
        "Zheng, Lv" <lv.zheng@...el.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "hanjun.guo@...aro.org" <hanjun.guo@...aro.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "jnair@...iumnetworks.com" <jnair@...iumnetworks.com>
Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable

On Thu, Jun 22, 2017 at 7:57 PM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
> On Thursday, June 22, 2017 02:13:18 PM Moore, Robert wrote:
>> This support is already in the ACPICA code base, but I can't speak to when it will be upstreamed to Linux. Lv would know this.
>
> It should be there in linux-next already AFAICS.
>
> Lorenzo, can you please double check?

thanks Rafael, this is added to linux-next on june12 [1].

When i sent my first version i.e on June 6, it was not there, hence i
have added to this series.
my bad, i have not checked when i sent subsequent versions.
this patch can be dropped.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/acpi/actbl1.h?id=a618c7f89a02f3c67a8f200855cff398855e3888

>
> Thanks,
> Rafael
>
>
>> > -----Original Message-----
>> > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@....com]
>> > Sent: Thursday, June 22, 2017 6:43 AM
>> > To: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>; Zheng, Lv
>> > <lv.zheng@...el.com>; Moore, Robert <robert.moore@...el.com>; Rafael J.
>> > Wysocki <rjw@...ysocki.net>
>> > Cc: linux-acpi@...r.kernel.org; devel@...ica.org; linux-
>> > kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
>> > marc.zyngier@....com; catalin.marinas@....com; will.deacon@....com;
>> > hanjun.guo@...aro.org; tglx@...utronix.de; jason@...edaemon.net;
>> > jnair@...iumnetworks.com; gpkulkarni@...il.com
>> > Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT
>> > subtable
>> >
>> > Hi Rafael, Lv, Robert,
>> >
>> > On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
>> > > Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
>> > >
>> > > ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
>> > > Link: https://github.com/acpica/acpica/commit/5bc67f6
>> > >
>> > > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@...ium.com>
>> > > ---
>> > >  include/acpi/actbl1.h | 12 +++++++++++-
>> > >  1 file changed, 11 insertions(+), 1 deletion(-)
>> >
>> > This patch is fine to me but it is up to you or who sends the ACPICA
>> > pull request to send it upstream or give us an ACK so that it can go via
>> > irqchip.
>> >
>> > We need to know how this commit (and other ACPICA changes) will be sent
>> > upstream to handle trees dependencies, please advise it is a bit urgent,
>> > thank you.
>> >
>> > Lorenzo
>> >
>> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
>> > > b4ce55c..253c9db 100644
>> > > --- a/include/acpi/actbl1.h
>> > > +++ b/include/acpi/actbl1.h
>> > > @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
>> > >   ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
>> > >   ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
>> > >   ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
>> > > - ACPI_SRAT_TYPE_RESERVED = 4     /* 4 and greater are reserved */
>> > > + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4,    /* ACPI 6.2 */
>> > > + ACPI_SRAT_TYPE_RESERVED = 5     /* 5 and greater are reserved */
>> > >  };
>> > >
>> > >  /*
>> > > @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
>> > >   u32 clock_domain;
>> > >  };
>> > >
>> > > +/* 4: GIC ITS Affinity (ACPI 6.2) */
>> > > +
>> > > +struct acpi_srat_its_affinity {
>> > > + struct acpi_subtable_header header;
>> > > + u32 proximity_domain;
>> > > + u16 reserved;
>> > > + u32 its_id;
>> > > +};
>> > > +
>> > >  /* Flags for struct acpi_srat_gicc_affinity */
>> > >
>> > >  #define ACPI_SRAT_GICC_ENABLED     (1)   /* 00: Use affinity structure
>> > */
>> > > --
>> > > 1.8.1.4
>> > >
>

thanks
Ganapat