linux-kernel - Re: [PATCH 13/32] ext4: ext4_xattr_value_same() should return false for external data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170622020441.qxkbtonyfia7hkuo@thunk.org>
Date:   Wed, 21 Jun 2017 22:04:41 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Tahsin Erdogan <tahsin@...gle.com>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 13/32] ext4: ext4_xattr_value_same() should return false
 for external data

On Wed, Jun 21, 2017 at 02:21:23PM -0700, Tahsin Erdogan wrote:
> ext4_xattr_value_same() is used as a quick optimization in case the new
> xattr value is identical to the previous value. When xattr value is
> stored in a xattr inode the check becomes expensive so it is better to
> just assume that they are not equal.
> 
> Signed-off-by: Tahsin Erdogan <tahsin@...gle.com>

Thanks, added to the ext4 patch queue.

					- Ted