linux-kernel - Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e121e9ad4afe49008e34b5b4a76b22c6@svr-chch-ex1.atlnz.lc>
Date:   Thu, 22 Jun 2017 21:20:59 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Wolfram Sang <wsa@...-dreams.de>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform

On 22/06/17 20:23, Wolfram Sang wrote:
> 
>> + - reset-gpios : gpio specifier for gpio connected to RESET_N pin.
> 
> What about the 'active' state that Rob mentioned in his last review?
> 

My intention was that by saying it is connected to the RESET_N bin the 
active state is covered.

I personally always get a little confused when talking about reset 
lines. The _N denotes that the line is active low but because it is a 
reset line writing 1 releases the reset so from a what-the-user-wants 
perspective it's active high.

dt-binding-wise what we want here is GPIO_ACTIVE_HIGH, as in the driver 
writes 1 to release reset so don't do any polarity inversion. I'd be 
happy do add something to that effect in a v3 but I actually felt saying 
the gpio is connected to RESET_N was less ambiguous.