linux-kernel - Re: [PATCH] kernel/extable.c: mark core_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1706230012150.2221@nanos>
Date:   Fri, 23 Jun 2017 00:16:36 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>
cc:     Marcin Nowakowski <marcin.nowakowski@...tec.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Thomas Meyer <thomas@...3r.de>, Ingo Molnar <mingo@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH] kernel/extable.c: mark core_kernel_text notrace

On Thu, 22 Jun 2017, Steven Rostedt wrote:
> On Wed, 21 Jun 2017 09:03:26 +0200
> Marcin Nowakowski <marcin.nowakowski@...tec.com> wrote:
> >  
> > -int core_kernel_text(unsigned long addr)
> > +int notrace core_kernel_text(unsigned long addr)
> 
> Is mips the only one with this issue. I hate adding notrace to general
> functions if it is only an issue with a single arch.

We have unwinders using that function and btw, ftrace has a similar issue
with core_kernel_data(). Probably not endless recursive, but not pretty
either if you have trace entries from within the tracer itself.

> Can we add a: mips_notrace? where we have:
> 
> #ifdef CONFIG_MIPS
> # define mips_notrace notrace
> #else 
> # define mips_notrace
> #endif

We can, but that will explode into an unholy mess sooner than later. I know
you'd love to come up with the most convoluted macro magic to make that
happen.

Thanks,

	tglx